Cppcodeandcichecks dec2024 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting that the "software check" workflow has really worked :) and successfully indeed! By the way, I'd suggest to have this version published/tagged as 0.4.3 (or whatever it corresponds) as I plan to work on big changes now (from the hackathon suggestions and similar) so we could move to 0.5.0 then and this will stay at the reference in case things get broken :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes mostly related to the C++ part that is in a preliminary release (not completed, but simple plots can already be made with it). It also contains some fixes and minor improvements (mostly for readability) to the python version, including the full compatability with python 2.7 (hopefully!) by removing all f-strings that were mistakenly left last time.
I have also implemented a workflow that should trigger at push and when opening a pull-request (testing this now :)). It just perform some basic checks on the software to prevent obvious programming mistakes. It checks the C++ compilation within ROOT and the python code (in both 3.X and 2.7).
Finally, I have added a few example codes in the tests directory. Mostly for internal checks, but I guess people can get ideas on how to use the code with working stand-alone examples (histograms and built-up on the fly).